This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323420: [clangd] Moved caching of compile commands to
ClangdServer (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42429?vs=131429&id=131432#toc
Repository:
ilya-biryukov updated this revision to Diff 131429.
ilya-biryukov marked 5 inline comments as done.
ilya-biryukov added a comment.
Herald added subscribers: hintonda, mgorny.
- Addressed review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42429
Files:
clangd/CMakeL
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for this cleanup!
The way we deal with ResourceDir still doesn't feel ideal, but that's no worse
here and everything else is better!
Comment at: clangd/ClangdS
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: ioeric, jkorous-apple, klimek.
It allows to get rid of CppFile::getLastCommand and simplify the
code in the upcoming threading patch.
Repository:
rCTE Clang Tools Extra
https://reviews.ll
