This revision was automatically updated to reflect the committed changes.
Closed by commit rL323382: [analyzer] Do not attempt to get the pointee of
void* (authored by alexshap, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42396?vs=130979&id=131352#toc
Repository:
rL LL
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yeah, i guess that'd work as well :)
Repository:
rL LLVM
https://reviews.llvm.org/D42396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
alexshap added a comment.
Herald added a reviewer: george.karpenkov.
switched to checking (*I)->getType()
Repository:
rL LLVM
https://reviews.llvm.org/D42396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
alexshap updated this revision to Diff 130979.
Repository:
rL LLVM
https://reviews.llvm.org/D42396
Files:
lib/StaticAnalyzer/Core/PathDiagnostic.cpp
test/Analysis/malloc.c
Index: test/Analysis/malloc.c
===
--- test/Analysis/
NoQ added a comment.
Hmm, the original code seems quite quick-and-dirty. It, indeed, tries to
blindly dereference something that's accidentally "some pointer".
Could you change the type check to consider AST types instead, i.e. check that
`(*I)->getType()` is a double-pointer type? And then pas
alexshap updated this revision to Diff 130967.
alexshap added a comment.
indents
Repository:
rL LLVM
https://reviews.llvm.org/D42396
Files:
lib/StaticAnalyzer/Core/PathDiagnostic.cpp
test/Analysis/malloc.c
Index: test/Analysis/malloc.c
==
alexshap created this revision.
alexshap added reviewers: NoQ, dcoughlin.
Herald added subscribers: llvm-commits, a.sidorin, szepet, xazax.hun.
Do not attempt to get the pointee of void* while generating a bug report
(otherwise it will trigger an assert inside RegionStoreManager::getBinding
asse
