This revision was automatically updated to reflect the committed changes.
Closed by commit rL323146: [analyzer] Protect against dereferencing a null
pointer (authored by alexshap, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42388?vs=130935&id=130946#toc
Repository:
rL
alexshap added a comment.
no, i have not seen any crashes related to this particular case, but i've been
working on a fix for a separate issue (a bit more involved) (not far from here)
(I will send a diff for review soon)
and decided to clean it up as well.
Repository:
rL LLVM
https://revi
NoQ accepted this revision.
NoQ added a reviewer: george.karpenkov.
NoQ added a comment.
This revision is now accepted and ready to land.
Neat. I wonder if you've actually found it by running the analyzer :) Did it
crash or just made sense to fix, i.e. should there be tests?
Repository:
rL LL
alexshap created this revision.
alexshap added reviewers: NoQ, dcoughlin.
Herald added subscribers: llvm-commits, a.sidorin, szepet, xazax.hun.
The check (inside StackHintGeneratorForSymbol::getMessage)
if (!N)
return getMessageForSymbolNotFound()
is moved to the beginning of the functio