This revision was automatically updated to reflect the committed changes.
Closed by commit rL323185: [ARM] Pass _Float16 as int or float (authored by
SjoerdMeijer, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42318?vs=131009&id=1310
samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.
Thanks for the explanation, LGTM, thanks!
https://reviews.llvm.org/D42318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
SjoerdMeijer updated this revision to Diff 131009.
SjoerdMeijer added a comment.
Moved the tests to the existing file (and fixed a few typos in the tests).
https://reviews.llvm.org/D42318
Files:
include/clang/AST/Type.h
lib/CodeGen/TargetInfo.cpp
test/CodeGen/arm-fp16-arguments.c
Index:
SjoerdMeijer added a comment.
Thanks for reviewing!
We are trying to achieve correct AAPCS parameter passing:
"If the argument is a Half-precision Floating Point Type its size is set to 4
bytes as if it
had been copied to the least significant bits of a 32-bit register and the
remaining bits
samparker added a comment.
Hi Sjoerd,
Seems sensible to me to treat these two types the same way, though I must admit
having different half types confuses me... So a few questions for my
understanding:
- What issue are you trying to workaround?
-What would the ideal solution be?
- Why do we
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: olista01, t.p.northover, rjmccall, aschwaighofer.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.
Pass and return _Float16 as if it were an int or float for ARM, but with the
top 16 bits unspecified, similarly like w
