[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

This revision was automatically updated to reflect the committed changes. Closed by commit rC323519: [ASTImporter] Support LambdaExprs and improve template support (authored by a.sidorin, committed by ). Changed prior to commit: https://reviews.llvm.org/D42301?vs=131279&id=131568#toc Repositor

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

a.sidorin added a comment. Thank you, Gabor. I'll change cast<> to cast_or_null<> to enable the assertion below. Repository: rC Clang https://reviews.llvm.org/D42301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Overall looks good! Thanks for working on this! Comment at: lib/AST/ExternalASTMerger.cpp:403 +ASTImporter *Importer = C.second; +NamedDecl *ND = cast(Importer-

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

xazax.hun added a comment. In https://reviews.llvm.org/D42301#986583, @a.sidorin wrote: > I'd rather create a separate patch - this one is already large enough. Is it > OK? Yeah, that is fine by me. Repository: rC Clang https://reviews.llvm.org/D42301 __

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

a.sidorin added a comment. In https://reviews.llvm.org/D42301#984695, @xazax.hun wrote: > High level note: `clang::TypeAliasDecl` has the same issue as > `CXXRecordDecl`, so templated versions should not be added to the > DeclContext. Could you add that just for the sake of completeness? I'd

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

a.sidorin updated this revision to Diff 131279. a.sidorin added a comment. Addressed review comments Repository: rC Clang https://reviews.llvm.org/D42301 Files: lib/AST/ASTImporter.cpp lib/AST/ASTStructuralEquivalence.cpp lib/AST/ExternalASTMerger.cpp test/ASTMerge/class-template/Inp

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

xazax.hun added a comment. In https://reviews.llvm.org/D42301#984713, @a.sidorin wrote: > > I do not see a test for the following changes: > > > > - ASTImporter: don't add templated declarations into DeclContext > > It's in ASTImporterTest. It checks that the templated decl cannot be found in >

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

a.sidorin added a comment. > I do not see a test for the following changes: > > - ASTImporter: don't add templated declarations into DeclContext It's in ASTImporterTest. It checks that the templated decl cannot be found in the enclosing TU. > - ASTImporter: proper set ParmVarDecls for imported

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

xazax.hun added a comment. I do not see a test for the following changes: - ASTImporter: don't add templated declarations into DeclContext - ASTImporter: proper set ParmVarDecls for imported FunctionProtoTypeLoc Comment at: lib/AST/ASTImporter.cpp:2085 + case FunctionDecl::TK

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

xazax.hun added a comment. High level note: `clang::TypeAliasDecl` has the same issue as `CXXRecordDecl`, so templated versions should not be added to the DeclContext. Could you add that just for the sake of completeness? Repository: rC Clang https://reviews.llvm.org/D42301 _

[PATCH] D42301: [ASTImporter] Support LambdaExprs and improve template support

a.sidorin created this revision. a.sidorin added reviewers: xazax.hun, szepet, jingham. a.sidorin added a project: clang. Herald added subscribers: rnkovacs, kristof.beyls, aemerson. Also, a number of style and bug fixes was done: - ASTImporterTest: added sanity check for source node - ExternalAS