[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323322: [libcxx] Correctly handle invalid regex character class names (authored by miyuki, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D422

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-24 Thread Mikhail Maltsev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323322: [libcxx] Correctly handle invalid regex character class names (authored by miyuki, committed by ). Repository: rCXX libc++ https://reviews.llvm.org/D42291 Files: include/regex test/std/r

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-19 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks fine to me. Thanks! Comment at: test/std/re/re.regex/re.regex.construct/bad_ctype.pass.cpp:28 +} catch (const std::regex_error &ex) { +result

[PATCH] D42291: [libcxx] Correctly handle invalid regex character class names

2018-01-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: EricWF, mclow.lists. Currently when a regular expression contains an invalid character class name std::regex constructors throw an std::regex_error with std::regex_constants::error_brack code. This patch changes the code to std::regex_constant