[PATCH] D42248: [LangOpts] Add a LangOpt to represent "#pragma region" support.

2018-01-18 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. Well, my understanding is that the pragma is a complete no-op even for MSVC, and is used only as a marker for editors such as Visual Studio's. So, unconditionally ignoring it would seem to be fine. https://reviews.llvm.org/D42248 ___

[PATCH] D42248: [LangOpts] Add a LangOpt to represent "#pragma region" support.

2018-01-18 Thread Matt Davis via Phabricator via cfe-commits
mattd added a comment. In https://reviews.llvm.org/D42248#980541, @majnemer wrote: > Why not always support the pragma regardless of the compiler mode? Our > "support" for it just ignores it anyway... Thanks for the reply @majnemer. I am not opposed to that idea. My change just operates simi

[PATCH] D42248: [LangOpts] Add a LangOpt to represent "#pragma region" support.

2018-01-18 Thread David Majnemer via Phabricator via cfe-commits
majnemer added a comment. Why not always support the pragma regardless of the compiler mode? Our "support" for it just ignores it anyway... https://reviews.llvm.org/D42248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D42248: [LangOpts] Add a LangOpt to represent "#pragma region" support.

2018-01-18 Thread Matt Davis via Phabricator via cfe-commits
mattd created this revision. mattd added reviewers: rnk, rsmith. Both MS and PS4 targets are capable of recognizing the existence of: #pragma region, #pragma endregion. This patch adds a LangOpt and sets the value based on target information or MS compatibility. In the case of PS4 or MS we shou