This revision was automatically updated to reflect the committed changes.
Closed by commit rL322749: [clang-format] Replace unordered_set with an array
(authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42189
Files:
bkramer accepted this revision.
bkramer added a comment.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D42189
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir updated this revision to Diff 130232.
krasimir added a comment.
- Add comment
Repository:
rC Clang
https://reviews.llvm.org/D42189
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- lib/Format/Format.
benhamilton accepted this revision.
benhamilton added a comment.
This revision is now accepted and ready to land.
Thanks, this is smarter.
Repository:
rC Clang
https://reviews.llvm.org/D42189
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
benhamilton added inline comments.
Comment at: lib/Format/Format.cpp:1424
const AdditionalKeywords &Keywords) {
-static const std::unordered_set FoundationIdentifiers = {
+static constexpr llvm::StringLiteral FoundationIdentifiers[] = {
krasimir updated this revision to Diff 130223.
krasimir added a comment.
- Address review comment
Repository:
rC Clang
https://reviews.llvm.org/D42189
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- lib/For
bkramer added inline comments.
Comment at: lib/Format/Format.cpp:1424
const AdditionalKeywords &Keywords) {
-static const std::unordered_set FoundationIdentifiers = {
+static const llvm::ArrayRef FoundationIdentifiers = {
"CGFloat",
---
krasimir created this revision.
krasimir added a reviewer: bkramer.
Herald added subscribers: cfe-commits, klimek.
krasimir added subscribers: benhamilton, jolesiak.
This replaces an unordered_set from r322690 with an array and binary search.
Repository:
rC Clang
https://reviews.llvm.org/D421
