This revision was automatically updated to reflect the committed changes.
Closed by commit rL322548: Ensure code complete with !LoadExternal sees all
local decls. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4207
sammccall updated this revision to Diff 129937.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Remove default value of PreserveInternalState, and move doc comment.
Repository:
rC Clang
https://reviews.llvm.org/D42077
Files:
include/clang/AST/DeclBase.h
include/cla
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a few NITs (see the comments)
Comment at: include/clang/AST/DeclBase.h:1826
lookups_range lookups() const;
- lookups_range noload_lookups() const;
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
noload_lookups() was too lazy: in addition to avoiding external decls, it
avoided populating the lazy lookup structure for internal decls.
This is the right behavior for the existing
