This revision was automatically updated to reflect the committed changes.
Closed by commit rL322509: [clangd] Improve const-correctness of
Symbol->Detail. NFC (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4205
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE322509: [clangd] Improve const-correctness of
Symbol->Detail. NFC (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42059?vs=129830&id=129895#toc
Repository:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LTGM.
Comment at: clangd/index/SymbolYAML.cpp:84
+ return nullptr;
+return new (*static_cast(IO.getContext()))
+T(std::move(*Opt));
woo, I l
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.
This would have caught a bug I wrote in an early version of
https://reviews.llvm.org/D42049, where
an index user could overwrite data internal to the index because th
