[PATCH] D42049: [clangd] Merge results from static/dynamic index.

2018-01-15 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL322480: [clangd] Merge results from static/dynamic index. (authored by sammccall, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42049 Files:

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

2018-01-15 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Comment at: clangd/index/Merge.cpp:34 + Dynamic->fuzzyFind(Ctx, Req, [&](const Symbol &S) { DynB.insert(S); }); + SymbolSlab Dyn = std::move(DynB).bu

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

2018-01-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clangd/index/Merge.cpp:29 + //b) if it's in the dynamic slab, merge it and yield the result + // 3) now yield all the dynamic symbols we haven't processed. + bool More = false; // We'll be incomplete if either source w

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

2018-01-15 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 129824. sammccall marked 2 inline comments as done. sammccall added a comment. Fixed bug where we wrote into the underlying index's symbols. Extended testcase. Added documentation around contracts. Repository: rCTE Clang Tools Extra https://reviews.llvm

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

2018-01-15 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clangd/index/Merge.cpp:29 + //b) if it's in the dynamic slab, merge it and yield the result + // 3) now yield all the dynamic symbols we haven't processed. + bool More = false; // We'll be incomplete if either source was.

[PATCH] D42049: [clangd] Merge results from static/dynamic index.

2018-01-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek. We now hide the static/dynamic split from the code completion, behind a new implementation of the SymbolIndex interface. This will reduce the complexity of the