This revision was automatically updated to reflect the committed changes.
Closed by commit rL322480: [clangd] Merge results from static/dynamic index.
(authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D42049
Files:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Comment at: clangd/index/Merge.cpp:34
+ Dynamic->fuzzyFind(Ctx, Req, [&](const Symbol &S) { DynB.insert(S);
});
+ SymbolSlab Dyn = std::move(DynB).bu
sammccall added inline comments.
Comment at: clangd/index/Merge.cpp:29
+ //b) if it's in the dynamic slab, merge it and yield the result
+ // 3) now yield all the dynamic symbols we haven't processed.
+ bool More = false; // We'll be incomplete if either source w
sammccall updated this revision to Diff 129824.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Fixed bug where we wrote into the underlying index's symbols.
Extended testcase.
Added documentation around contracts.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm
hokein added inline comments.
Comment at: clangd/index/Merge.cpp:29
+ //b) if it's in the dynamic slab, merge it and yield the result
+ // 3) now yield all the dynamic symbols we haven't processed.
+ bool More = false; // We'll be incomplete if either source was.
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek.
We now hide the static/dynamic split from the code completion, behind a
new implementation of the SymbolIndex interface. This will reduce the
complexity of the
