[PATCH] D41958: Create a deduction guide for basic_string

2018-03-06 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists closed this revision. mclow.lists added a comment. This was landed as r324619 https://reviews.llvm.org/D41958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41958: Create a deduction guide for basic_string

2018-01-11 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM other than inline comments. Comment at: include/string:1491 +#if _LIBCPP_STD_VER > 14 +templatehttps://reviews.llvm.org/D41958 _

[PATCH] D41958: Create a deduction guide for basic_string

2018-01-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists created this revision. mclow.lists added a reviewer: EricWF. First of the C++17 deduction guides (I think). Uses the new `__is_allocator` trait. The failing test is not quite right yet, but the success bits all work. https://reviews.llvm.org/D41958 Files: include/string test/st