This revision was automatically updated to reflect the committed changes.
Closed by commit rC323195: [Tooling] Added a VFS parameter to ClangTool
(authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41947?vs=130573&id=131045#toc
Repository:
rC Clang
htt
vladimir.plyashkun updated this revision to Diff 130573.
vladimir.plyashkun added a comment.
Fixed comment
Repository:
rC Clang
https://reviews.llvm.org/D41947
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling.cpp
unittests/Tooling/ToolingTest.cpp
Index: unittests/Tooling/To
ilya-biryukov added inline comments.
Comment at: include/clang/Tooling/Tooling.h:299
/// clang modules.
+ /// \param BaseFS Base virtual filesystem used for OverlayFileSystem creation
ClangTool(const CompilationDatabase &Compilations,
NIT: LLVM coding styl
ilya-biryukov added a comment.
In https://reviews.llvm.org/D41947#980305, @vladimir.plyashkun wrote:
> In https://reviews.llvm.org/D41947#980298, @ilya-biryukov wrote:
>
> > Looks good. Do you have commit access or do you need someone to land this
> > patch for you?
>
>
> No, i don't have commit
vladimir.plyashkun added a comment.
In https://reviews.llvm.org/D41947#980298, @ilya-biryukov wrote:
> Looks good. Do you have commit access or do you need someone to land this
> patch for you?
No, i don't have commit access.
Repository:
rC Clang
https://reviews.llvm.org/D41947
___
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
Looks good. Do you have commit access or do you need someone to land this patch
for you?
Repository:
rC Clang
https://reviews.llvm.org/D41947
_
vladimir.plyashkun updated this revision to Diff 130382.
vladimir.plyashkun added a comment.
Implemented test-case to check that `BaseFS` is actually used in `ClangTool`
Repository:
rC Clang
https://reviews.llvm.org/D41947
Files:
include/clang/Tooling/Tooling.h
lib/Tooling/Tooling.cpp
ilya-biryukov added a comment.
LGTM, but could we add a test that checks the VFS is actually used?
Repository:
rC Clang
https://reviews.llvm.org/D41947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
