[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple closed this revision. jkorous-apple added a comment. Landed as git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@322438 91177308-0d34-0410-b5e6-96231b3b80d8 https://reviews.llvm.org/D41897 ___ cfe-commits mailing list cfe-commit

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple added a comment. I do. Will commit this in a minute. https://reviews.llvm.org/D41897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41897: Fixing a crash in Sema.

aaron.ballman added a comment. In https://reviews.llvm.org/D41897#974618, @jkorous-apple wrote: > Thank you! Do you have commit privileges, or would you like me to commit this on your behalf? https://reviews.llvm.org/D41897 ___ cfe-commits maili

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple added a comment. Thank you! https://reviews.llvm.org/D41897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41897: Fixing a crash in Sema.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! https://reviews.llvm.org/D41897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple updated this revision to Diff 129631. jkorous-apple added a comment. Fixed test based on Aaron's comments. https://reviews.llvm.org/D41897 Files: Sema/SemaDeclCXX.cpp SemaCXX/base-class-ambiguity-check.cpp Index: SemaCXX/base-class-ambiguity-check.cpp ===

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple added inline comments. Comment at: SemaCXX/base-class-ambiguity-check.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s + aaron.ballman wrote: > jkorous-apple wrote: > > aaron.ballman wrote: > > > jkorous-apple wrote: > > > > aaron.ballman wrote: > > > > >

[PATCH] D41897: Fixing a crash in Sema.

aaron.ballman added inline comments. Comment at: SemaCXX/base-class-ambiguity-check.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s + jkorous-apple wrote: > aaron.ballman wrote: > > jkorous-apple wrote: > > > aaron.ballman wrote: > > > > This run line isn't testing an

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple added inline comments. Comment at: Sema/SemaDeclCXX.cpp:2426 +// Skip all dependent types in templates being used as base specifiers. +// Checks below assume that base specifier is a CXXRecord. +if (BaseType->isDependentType()) { aaron.b

[PATCH] D41897: Fixing a crash in Sema.

aaron.ballman added inline comments. Comment at: SemaCXX/base-class-ambiguity-check.cpp:1 +// RUN: %clang_cc1 -fsyntax-only %s + aaron.ballman wrote: > This run line isn't testing anything. Since you're trying to ensure this > doesn't crash, I would put `-verify

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple updated this revision to Diff 129284. jkorous-apple added a comment. Changes based on Aaron's feedback. https://reviews.llvm.org/D41897 Files: Sema/SemaDeclCXX.cpp SemaCXX/base-class-ambiguity-check.cpp Index: SemaCXX/base-class-ambiguity-check.cpp ==

[PATCH] D41897: Fixing a crash in Sema.

aaron.ballman added reviewers: rsmith, aaron.ballman. aaron.ballman added inline comments. Comment at: Sema/SemaDeclCXX.cpp:2426 +// Skip all dependent types in templates being used as base specifiers. +// Checks below assume that base specifier is a CXXRecord. +if (B

[PATCH] D41897: Fixing a crash in Sema.

jkorous-apple created this revision. jkorous-apple added a reviewer: arphaman. The original code is checking for inaccessible base classes but does not expect inheriting from template parameters (or dependent types in general) as these are not modelled by CXXRecord. Issue was at this line since