modocache added a comment.
Great, thanks for the review, @v.g.vassilev!
Repository:
rC Clang
https://reviews.llvm.org/D41867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322118: [Frontend] Remove unused FileMgr in pp arg parse
(authored by modocache, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41867?vs=129089&id=129152#toc
Repository:
rC Clang
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D41867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
modocache created this revision.
modocache added a reviewer: v.g.vassilev.
A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203
mentioned that a FileManager should not need to be used when parsing
preprocessor arguments. In fact, its only use was removed 6 years ago
(2012), in htt