[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-24 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a comment. Great, thanks for the reviews! Repository: rC Clang https://reviews.llvm.org/D41820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-24 Thread Brian Gesiak via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323381: [coroutines] Pass coro func args to promise ctor (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D41820 Files: c

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-24 Thread Brian Gesiak via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC323381: [coroutines] Pass coro func args to promise ctor (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D41820?vs=129785&id=131351#toc Repository: rC Clang

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-23 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D41820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-14 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 129785. modocache added a comment. Thanks for the great review, @GorNishanov! You were exactly right, I had to remove the assert. I've taken all of your other suggestions as well. Let me know if anything else stands out at you. Also, thanks for the questio

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-12 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added a comment. In https://reviews.llvm.org/D41820#974116, @EricWF wrote: > Is this behavior specified somewhere? Or are we simply adding an extension to > Clang? If so I would really prefer to add my `co_promise` solution (but I > need to write a paper in favor of it first). Bef

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-12 Thread Eric Niebler via Phabricator via cfe-commits
eric_niebler added a comment. > Is this behavior specified somewhere? Or are we simply adding an extension to > Clang? It is not specified anywhere //yet// but Gor has promised a paper for Jacksonville. > If so I would really prefer to add my co_promise solution (but I need to > write a paper

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-11 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Is this behavior specified somewhere? Or are we simply adding an extension to Clang? If so I would really prefer to add my `co_promise` solution (but I need to write a paper in favor of it first). Repository: rC Clang https://reviews.llvm.org/D41820 __

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-10 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov requested changes to this revision. GorNishanov added a comment. This revision now requires changes to proceed. Thank you for doing this change! Comment at: lib/Sema/SemaCoroutine.cpp:475 +// Create a static_cast\(expr). +static Expr *castForMoving(Sema &S, Expr *

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

2018-01-08 Thread Brian Gesiak via Phabricator via cfe-commits
modocache created this revision. modocache added reviewers: rsmith, GorNishanov, eric_niebler. Herald added a subscriber: EricWF. Use corutine function arguments to initialize a promise type, but only if the promise type defines a constructor that takes those arguments. Otherwise, fall back to the