This revision was automatically updated to reflect the committed changes.
steven_wu marked an inline comment as done.
Closed by commit rL321909: Preserve unknown STDC pragma through preprocessor
(authored by steven_wu, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41780
Files:
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
steven_wu updated this revision to Diff 128794.
steven_wu added a comment.
Move STDC pragma handler to parser.
Repository:
rC Clang
https://reviews.llvm.org/D41780
Files:
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Basic/DiagnosticParseKinds.td
include/clang/Parse/Parser.h
efriedma added a comment.
Should be safe, I think; currently, FENV_ACCESS and CX_LIMITED_RANGE have no
effect, and when we do start supporting them, we'll probably want to handle
them in the parser, like we do for FP_CONTRACT.
Repository:
rC Clang
https://reviews.llvm.org/D41780
steven_wu added a comment.
In https://reviews.llvm.org/D41780#968664, @efriedma wrote:
> If you move all the #pragma STDC handlers from the lexer to the parser, you
> might be able to avoid adding an explicit STDC handler in
> PrintPreprocessedOutput.cpp.
If it is safe to do that, I can chang
efriedma added a comment.
If you move all the #pragma STDC handlers from the lexer to the parser, you
might be able to avoid adding an explicit STDC handler in
PrintPreprocessedOutput.cpp.
Comment at: test/Preprocessor/pragma_unknown.c:32
#pragma STDC SO_GREAT // expected-w
steven_wu created this revision.
steven_wu added reviewers: efriedma, rsmith, arphaman.
should keep the unknown STDC pragma through preprocessor and we also
should not emit warning for unknown STDC pragma during preprocessor.
rdar://problem/35724351
Repository:
rC Clang
https://reviews.llvm.