This revision was automatically updated to reflect the committed changes.
Closed by commit rL322084: [clangd] Use ToolExecutor to write the
global-symbol-builder tool. (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D41
ioeric added a comment.
In https://reviews.llvm.org/D41730#970704, @sammccall wrote:
> This makes `SymbolCollector` (production code) depend on YAML (explicitly
> experimental), as well as on Tooling interfaces.
> At least we should invert this by making the thing passed to SymbolCollector
> a
ioeric updated this revision to Diff 129063.
ioeric added a comment.
Address review comment: move all ToolExecutor and YAML-specific logics out of
SymbolCollector.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41730
Files:
clangd/global-symbol-builder/GlobalSymbolBuilderMai
sammccall added a comment.
This makes `SymbolCollector` (production code) depend on YAML (explicitly
experimental), as well as on Tooling interfaces.
At least we should invert this by making the thing passed to SymbolCollector a
`function` or so.
Moreover, it's unfortunate we'd need to change S
ioeric updated this revision to Diff 128723.
ioeric marked 2 inline comments as done.
ioeric added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41730
Files:
clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
clangd/index/SymbolCol
ioeric added inline comments.
Comment at: clangd/index/SymbolYAML.cpp:140
llvm::yaml::Output Yout(OS);
for (Symbol S : Symbols) // copy: Yout<< requires mutability.
Yout<< S;
hokein wrote:
> The function could be simplified by using the SymbolToYAML be
hokein added a comment.
The implementation looks good, but to see whether sam has high-level comments
on this.
Comment at: clangd/index/SymbolYAML.cpp:140
llvm::yaml::Output Yout(OS);
for (Symbol S : Symbols) // copy: Yout<< requires mutability.
Yout<< S;
--
ioeric created this revision.
ioeric added reviewers: hokein, sammccall.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.
This enables more execution modes like standalone and Mapreduce-style execution.
See also https://reviews.llvm.org/D41729
Repository:
rCTE Clang Tools Extra
