This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX325510: [libcxx] Improve accuracy of complex asinh and
acosh (authored by miyuki, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41629
Files:
include/complex
test/libcxx/numer
miyuki added a comment.
No, I'll commit it myself. Thank you for the review.
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM. Do you need me to commit this?
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
miyuki added a comment.
Herald added a subscriber: christof.
ping
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki updated this revision to Diff 133408.
miyuki added a comment.
Added a test for __sqr
https://reviews.llvm.org/D41629
Files:
include/complex
test/libcxx/numerics/complex.number/__sqr.pass.cpp
test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp
test/std/numerics
mclow.lists added a comment.
This all looks good to me.
I think that one more test should be added - and that's one that tests `__sqr`
directly.
Since that's not a public routine, the test should go in
"test/libcxx/numerics/complex.number"
https://reviews.llvm.org/D41629
___
miyuki added a comment.
ping^3
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
ping^2
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
ping
https://reviews.llvm.org/D41629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added inline comments.
Comment at:
test/std/numerics/complex.number/complex.transcendentals/acosh.pass.cpp:59
+{
+assert(r.real() == 0);
+assert(!std::signbit(r.real()));
Ideally, I would prefer some approximate comparison
miyuki created this revision.
miyuki added reviewers: EricWF, mclow.lists.
Currently std::asinh and std::acosh use std::pow to compute x^2. This
results in a significant error when computing e.g. asinh(i) or
acosh(-1).
This patch expresses x^2 directly via x.real() and x.imag(), like it
is done i
11 matches
Mail list logo
