hintonda added a comment.
In https://reviews.llvm.org/D41623#982262, @hintonda wrote:
> In https://reviews.llvm.org/D41623#982189, @phosek wrote:
>
> > Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as
> > well.
>
>
> Unfortunately no.
>
> When cross compiling, it's impor
hintonda added a comment.
In https://reviews.llvm.org/D41623#982189, @phosek wrote:
> Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as
> well.
Unfortunately no.
When cross compiling, it's important to look for headers in CMAKE_SYSROOT
and/or CMAKE_FIND_ROOT_PATH, or
phosek added a comment.
Isn't `NO_DEFAULT_PATH` more appropriate here? That's what libc++ uses as well.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
hintonda added a comment.
Unless there's any further comment, I plan to commit these patches tomorrow.
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
hintonda added a comment.
ping...
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hintonda added a comment.
In https://reviews.llvm.org/D41623#965271, @compnerd wrote:
> I think that it might be better to handle this as a single global change:
>
> if(CMAKE_FIND_ROOT_PATH)
> set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE NEVER)
> endif()
When I cross compile on Darwin and targ
compnerd added a comment.
I think that it might be better to handle this as a single global change:
if(CMAKE_FIND_ROOT_PATH)
set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE NEVER)
endif()
Repository:
rCXXA libc++abi
https://reviews.llvm.org/D41623
___
