[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

hintonda updated this revision to Diff 130820. hintonda added a comment. - Save CMAKE_REQUIRED_FLAGS for another patch. Repository: rCXX libc++ https://reviews.llvm.org/D41622 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

hintonda added a comment. ping... Repository: rCXX libc++ https://reviews.llvm.org/D41622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

hintonda added a comment. Btw, here's the WIP toolchain file I"m using, which might help clear up why these changes is necessary: https://github.com/donhinton/misc/blob/master/cmake/linux-toolchain.cmake Repository: rCXX libc++ https://reviews.llvm.org/D41622 __

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

hintonda added a comment. In https://reviews.llvm.org/D41622#965280, @phosek wrote: > Would it be possible to split the `CMAKE_REQUIRED_FLAGS` fix into a separate > change since it's unrelated to the `CMAKE_FIND_ROOT_PATH` bit? Sure, but both are needed to actually work. This fixes cross comp

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

phosek added a comment. Would it be possible to split the `CMAKE_REQUIRED_FLAGS` fix into a separate change since it's unrelated to the `CMAKE_FIND_ROOT_PATH` bit? Repository: rCXX libc++ https://reviews.llvm.org/D41622 ___ cfe-commits mailing l

[PATCH] D41622: [cmake] [libcxx] Fix path and flag problems when cross compiling.

compnerd added a comment. Similar to the libc++abi wrt `find_path`. The `CMAKE_REQUIRED_FLAGS` handling LGTM. Repository: rCXX libc++ https://reviews.llvm.org/D41622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/