coby closed this revision.
coby added a comment.
closed by commit https://reviews.llvm.org/rC321474
(https://reviews.llvm.org/rL321474)
Repository:
rC Clang
https://reviews.llvm.org/D41583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41583
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
coby updated this revision to Diff 128185.
coby added a comment.
turning aes off forbids enabling vaes
Repository:
rC Clang
https://reviews.llvm.org/D41583
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets/X86.cpp
lib/Basic/Targets/X86.h
l
I see. agreed. Will upload shortly
From: Craig Topper [mailto:craig.top...@gmail.com]
Sent: Tuesday, December 26, 2017 19:52
To: reviews+d41583+public+5c6eea8282599...@reviews.llvm.org
Cc: cfe-commits@lists.llvm.org; Tayree, Coby ;
mgo...@gentoo.org
Subject: Re: [PATCH] D41583: [x86][icelake
I meant if the command line says “-mvaes -mno-aes” we should make sure to
disable vaes
On Tue, Dec 26, 2017 at 9:47 AM coby via Phabricator <
revi...@reviews.llvm.org> wrote:
> coby added inline comments.
>
>
>
> Comment at: lib/Basic/Targets/X86.cpp:573
> setMMXLevel(Featur
coby added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:573
setMMXLevel(Features, AMD3DNowAthlon, Enabled);
} else if (Name == "aes") {
if (Enabled)
craig.topper wrote:
> Shouldn't -aes imply -vaes?
how come? perhaps i'm missing here someth
craig.topper added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:573
setMMXLevel(Features, AMD3DNowAthlon, Enabled);
} else if (Name == "aes") {
if (Enabled)
Shouldn't -aes imply -vaes?
Repository:
rC Clang
https://reviews.llvm.org/D415
coby created this revision.
coby added a reviewer: craig.topper.
Herald added a subscriber: mgorny.
added intrinsics support for vaes instructions, matching a similar work on the
backend (https://reviews.llvm.org/D40078)
Repository:
rC Clang
https://reviews.llvm.org/D41583
Files:
include/
