hamzasood updated this revision to Diff 156681.
hamzasood added a comment.
- Fixed the premature loop termination issue pointed out by @rsmith (and added
a test case for it).
- Fixed a few small issues regarding diagnosing exported enum/struct/union
declarations without a name (especially anonym
rsmith added inline comments.
Comment at: include/clang/AST/DeclBase.h:2055-2075
+template<>
+struct GraphTraits {
+ using NodeRef = const ::clang::Decl *;
+ using ChildIteratorType = ::clang::DeclContext::decl_iterator;
+
+ static NodeRef getEntryNode(const ::clang::DeclConte
hamzasood updated this revision to Diff 128302.
hamzasood added a comment.
I've removed the `isExported` fix for namespaces as it's somewhat unrelated to
this patch.
I'll do a separate patch for fixing namespaces (which will include the stuff
removed from here and a bit more)
https://reviews.l
hamzasood created this revision.
hamzasood added reviewers: rsmith, bruno, boris.
Diagnose attempts to export declarations with internal linkage, as mentioned in
`[dcl.module.interface]p2` in the Modules TS.
I would've liked to add a FixIt hint to remove the static keyword if present,
but I cou
