aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks for the detailed review! I've commit in r324890.
https://reviews.llvm.org/D41553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
No, this LGTM.
https://reviews.llvm.org/D41553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
aaron.ballman updated this revision to Diff 133791.
aaron.ballman added a comment.
Added the remaining ObjC, NS, and CF attributes. I think that's the last of the
Apple-related attributes (I plan to continue to work on the other attributes as
well, but in separate patches). @rjmccall, do you see
rjmccall added inline comments.
Comment at: lib/Parse/ParseObjc.cpp:1434
MaybeParseGNUAttributes(paramAttrs);
- ArgInfo.ArgAttrs = paramAttrs.getList();
}
aaron.ballman wrote:
> rjmccall wrote:
> > ObjC parameter syntax is really its own weird
aaron.ballman marked 5 inline comments as done.
aaron.ballman added inline comments.
Comment at: lib/Parse/ParseObjc.cpp:1434
MaybeParseGNUAttributes(paramAttrs);
- ArgInfo.ArgAttrs = paramAttrs.getList();
}
rjmccall wrote:
> ObjC parameter syn
aaron.ballman updated this revision to Diff 131860.
aaron.ballman added a comment.
Updates based on review feedback.
https://reviews.llvm.org/D41553
Files:
include/clang/Basic/Attr.td
include/clang/Parse/Parser.h
lib/Parse/ParseObjc.cpp
lib/Parse/Parser.cpp
test/Misc/ast-dump-attr.m
rjmccall added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
aaron.ballman wrote:
> rjmccall wrote:
> > aaron.ballman wrote:
> > > rjmccall wrote:
> > > > aaron.ballman wrote:
> > > > > rjmccall wrote:
> > > > > > I
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
rjmccall wrote:
> aaron.ballman wrote:
> > rjmccall wrote:
> > > aaron.ballman wrote:
> > > > rjmccall wrote:
> > > > > I have no objection to allowi
rjmccall added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
aaron.ballman wrote:
> rjmccall wrote:
> > aaron.ballman wrote:
> > > rjmccall wrote:
> > > > I have no objection to allowing ObjC attributes to be spelle
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
rjmccall wrote:
> aaron.ballman wrote:
> > rjmccall wrote:
> > > I have no objection to allowing ObjC attributes to be spelled in
> > > [[clang::obj
rjmccall added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
aaron.ballman wrote:
> rjmccall wrote:
> > I have no objection to allowing ObjC attributes to be spelled in
> > [[clang::objc_whatever]] style. We can d
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
rjmccall wrote:
> I have no objection to allowing ObjC attributes to be spelled in
> [[clang::objc_whatever]] style. We can debate giving them a mo
rjmccall added inline comments.
Comment at: include/clang/Basic/Attr.td:239
+ bit IncludeC = includeC;
+}
I have no objection to allowing ObjC attributes to be spelled in
[[clang::objc_whatever]] style. We can debate giving them a more appropriate
standard
aaron.ballman added a comment.
Post-holiday ping.
https://reviews.llvm.org/D41553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added reviewers: rjmccall, arphaman, ahatanak.
aaron.ballman added a comment.
In https://reviews.llvm.org/D41553#963536, @rsmith wrote:
> This appears to add attributes on some Obj-C constructs as an on-by-default
> feature in Obj-C++11 onwards; it needs review by folks more heavil
rsmith added a comment.
This appears to add attributes on some Obj-C constructs as an on-by-default
feature in Obj-C++11 onwards; it needs review by folks more heavily involved in
the Obj-C language design and direction to confirm that this makes sense and
(ideally) to update the Obj-C document
aaron.ballman added a comment.
This patch depends on https://reviews.llvm.org/D41317 for the modifications to
the Clang<> attribute spelling.
https://reviews.llvm.org/D41553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
aaron.ballman created this revision.
aaron.ballman added a reviewer: rsmith.
One plausible use for the new double square-bracket attribute support in C are
attributes appertaining to Objective-C constructs. This patch adds parsing
support for such attributes and exposes a handful of ObjC attribu
18 matches
Mail list logo
