This revision was automatically updated to reflect the committed changes.
Closed by commit rL321411: [Index] Reduce size of SymbolInfo struct. (authored
by sammccall, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41514
Files:
cfe/trunk/include/clang/Index/IndexSymbol.h
cfe
akyrtzi accepted this revision.
akyrtzi added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D41514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
sammccall updated this revision to Diff 127986.
sammccall added a comment.
Avoid repeating uint8_t type for SymbolProperty/SymbolPropertySet.
Repository:
rC Clang
https://reviews.llvm.org/D41514
Files:
include/clang/Index/IndexSymbol.h
lib/Index/IndexSymbol.cpp
tools/libclang/CXIndexDa
akyrtzi added a comment.
Nice one! One minor change I'd suggest is to change `SymbolProperty` to `enum
class SymbolProperty : SymbolPropertySet`, so that if it needs to increase we
only change the type in one place.
Repository:
rC Clang
https://reviews.llvm.org/D41514
___
sammccall created this revision.
sammccall added a reviewer: akyrtzi.
Herald added subscribers: cfe-commits, ilya-biryukov.
This is currently 16 bytes, the patch reduces it to 4.
(Building with clang on linux x84, I guess others are similar)
The only subfield that might need a bigger type is Symb
