This revision was automatically updated to reflect the committed changes.
Closed by commit rL321358: [clangd] Add a tool to build YAML-format global
symbols. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41491?vs=128021&id=128022#toc
Repository:
rL L
hokein updated this revision to Diff 128021.
hokein marked an inline comment as done.
hokein added a comment.
Use GeneralCateogry.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41491
Files:
clangd/CMakeLists.txt
clangd/global-symbol-builder/CMakeLists.txt
clangd/global-s
sammccall added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:45
+IndexOpts.SystemSymbolFilter =
+index::IndexingOptions::SystemSymbolFilterKind::All;
+IndexOpts.IndexFunctionLocals = false;
hokein wrote:
>
hokein updated this revision to Diff 128020.
hokein marked 4 inline comments as done.
hokein added a comment.
Address remaining review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41491
Files:
clangd/CMakeLists.txt
clangd/global-symbol-builder/CMakeLists.txt
c
hokein added a comment.
In https://reviews.llvm.org/D41491#963103, @sammccall wrote:
> Thanks for the simplification!
> How long does it take to run over LLVM on your machine?
It took < 10 minutes (vs 20 minutes with python script) to run over LLVM.
Comment at: clangd/globa
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks for the simplification!
How long does it take to run over LLVM on your machine?
Comment at: clangd/CMakeLists.txt:50
add_subdirectory(tool)
+add_subdirectory(gl
hokein added a comment.
Thanks for the comments.
Comment at: clangd/CMakeLists.txt:50
add_subdirectory(tool)
+add_subdirectory(global-symbol-builder)
sammccall wrote:
> I think generally we run `check-clang-tools` before committing - I guess it's
> OK not to
hokein updated this revision to Diff 128010.
hokein marked 4 inline comments as done.
hokein added a comment.
Write all map-reduce logic into the global-symbol-builder binary, which makes
the patch much simpler.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41491
Files:
clan
sammccall added a comment.
This looks like it does the right thing, ISTM it has a few too many moving
parts.
I might be missing why they're necessary, or we might not want to bother
polishing this - maybe you can give me more context offline.
Repository:
rCTE Clang Tools Extra
https://revie
sammccall added inline comments.
Comment at: clangd/CMakeLists.txt:50
add_subdirectory(tool)
+add_subdirectory(global-symbol-builder)
I think generally we run `check-clang-tools` before committing - I guess it's
OK not to have tests for this experimental tool,
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ilya-biryukov, mgorny, klimek.
The tools is used to generate global symbols for clangd (global code
completion),
The format is YAML, which is only for **experiment**.
TEST: used the tool to generate globa
11 matches
Mail list logo
