This revision was automatically updated to reflect the committed changes.
Closed by commit rC321757: Calculate size of buffer instead of using a magic
value. (authored by probinson, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41421
Files:
lib/Frontend/PrintPreprocessedOut
mattd added a comment.
Ping :) I would like someone to commit this on my behalf, thanks!
https://reviews.llvm.org/D41421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mattd added a comment.
Thanks Eli! I do not have commit permissions, so someone else will have to
commit this on my behalf.
https://reviews.llvm.org/D41421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D41421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
mattd updated this revision to Diff 127641.
mattd added a comment.
Thanks for the suggestion Eli. Took your initial suggestion.
https://reviews.llvm.org/D41421
Files:
lib/Frontend/PrintPreprocessedOutput.cpp
Index: lib/Frontend/PrintPreprocessedOutput.cpp
==
efriedma added a comment.
Please use llvm::array_lengthof to compute the length of an array.
Alternatively, there's an overload of PP.getSpelling which takes a SmallVector
and returns a StringRef as a parameter; you could change this code to use it,
which would remove the need for the check.
mattd created this revision.
mattd added a reviewer: bkramer.
Calculate sizeof Buffer instead of using a magic value.
https://reviews.llvm.org/D41421
Files:
PrintPreprocessedOutput.cpp
Index: PrintPreprocessedOutput.cpp
===
---
