[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. Herald added a subscriber: sanjoy.google. @ericwf and @timshen, @Maxf and I are indeed very interested in seeing this library upstreamed soon. Over the last weeks, we developed a software prototype based on these bindings and already started to tune performance on clang/

[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. @EricWF thanks again for offering your help here. We are not in a rush here, but I wonder if you happen to have a rough estimate when you might have the time to look into these patches? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41412/new/ https://reviews.l

[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. In D41412#1592152 , @timshen wrote: > Tobias, > > I spoke to @EricWF who is willing to take a look at all these patches. > However, I don't know when exactly will the review starts. Amazing. I am super interested in seeing this

[PATCH] D41412: [libcxx] implement concat() and split()

timshen added a comment. Tobias, I spoke to @EricWF who is willing to take a look at all these patches. However, I don't know when exactly will the review starts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41412/new/ https://reviews.llvm.org/D41412 __

[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. It seems this patch went through at least one review and the only open comment is the discussion if __builtin_shuffle should be placed in the configuration. From my perspective, both solutions are technically feasible. While it seems unlikely that gcc will gain this spe

[PATCH] D41412: [libcxx] implement concat() and split()

timshen added a comment. In D41412#1586966 , @grosser wrote: > Hi @timshen, > > I am very interested in these patches. Any chance you can take up the > upstreaming process again? I'm glad to spend time upstreaming these patches. Now we just need a libc+

[PATCH] D41412: [libcxx] implement concat() and split()

grosser added a comment. Hi @timshen, I am very interested in these patches. Any chance you can take up the upstreaming process again? Best, Tobias CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41412/new/ https://reviews.llvm.org/D41412

[PATCH] D41412: [libcxx] implement concat() and split()

timshen added a comment. A note on test cases: I only used simds ints to test split() and concat(), as both functions don't specialize on the element type, unlike the constructors. Comment at: libcxx/include/experimental/simd:1491 - template + template static constexp

[PATCH] D41412: [libcxx] implement concat() and split()

timshen updated this revision to Diff 158092. timshen marked 2 inline comments as done. timshen edited the summary of this revision. timshen added a comment. Update based on comments. https://reviews.llvm.org/D41412 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/s

[PATCH] D41412: [libcxx] implement concat() and split()

mclow.lists added inline comments. Herald added subscribers: bixia, jlebar. Comment at: libcxx/include/experimental/simd:994 + +// NOTE: _Abis... is the extension proposed by P0820, allowing the APIs to +// propagate _StorageKind during transforming input type(s) to the output ty

[PATCH] D41412: [libcxx] implement concat() and split()

timshen updated this revision to Diff 139038. timshen added a comment. Herald added a subscriber: christof. Rebase. https://reviews.llvm.org/D41412 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.horizontal/concat.pass.cpp libcxx/test/std/experimental/simd/s

[PATCH] D41412: [libcxx] implement concat() and split()

timshen updated this revision to Diff 129009. timshen added a comment. Rebased. https://reviews.llvm.org/D41412 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.horizontal/concat.pass.cpp libcxx/test/std/experimental/simd/simd.horizontal/split.pass.cpp Index

[PATCH] D41412: [libcxx] implement concat() and split()

timshen created this revision. timshen added reviewers: mclow.lists, EricWF. Herald added a subscriber: sanjoy. This patch implements the extended version (see P0820) of P0214 concat() and split(). https://reviews.llvm.org/D41412 Files: libcxx/include/experimental/simd libcxx/test/std/exper