[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2018-01-02 Thread Tim Shen via Phabricator via cfe-commits
timshen added a comment. In https://reviews.llvm.org/D41386#966189, @mstorsjo wrote: > In https://reviews.llvm.org/D41386#966187, @timshen wrote: > > > The static_assert on line 1189 fails with the following build on x86: > > > > cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON > > -DLLVM_P

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2018-01-02 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In https://reviews.llvm.org/D41386#966187, @timshen wrote: > The static_assert on line 1189 fails with the following build on x86: > > cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON > -DLLVM_PATH=$PATH_TO_LLVM $PATH_TO_LIBUNWIND && ninja libunwind.a > > > It s

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2018-01-02 Thread Tim Shen via Phabricator via cfe-commits
timshen added a comment. The static_assert on line 1189 fails with the following build on x86: cmake -GNinja -DLIBUNWIND_ENABLE_CROSS_UNWINDING=ON -DLLVM_PATH=$PATH_TO_LLVM $PATH_TO_LIBUNWIND && ninja libunwind.a It seems that 136 in `# define _LIBUNWIND_CONTEXT_SIZE 136` is too small. Rever

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2018-01-02 Thread Martin Storsjö via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL321667: [PPC64] Port to ppc64le - initial version (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D41386?vs=127516&id=128445#toc Repository: rL LLVM https://

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2018-01-02 Thread Leandro Lupori via Phabricator via cfe-commits
luporl marked an inline comment as done. luporl added a comment. @compnerd, @mstorsjo, I don't have permission to commit to the repository. Could you check in the changes for me? https://reviews.llvm.org/D41386 ___ cfe-commits mailing list cfe-comm

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2017-12-19 Thread Leandro Lupori via Phabricator via cfe-commits
luporl marked 3 inline comments as done. luporl added inline comments. Comment at: src/libunwind.cpp:84 #ifdef UNW_REMOTE +//TODO: add powerpc64 support /// Create a cursor into a thread in another process. mstorsjo wrote: > Why this comment here? Remote unwind

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2017-12-19 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. No further comments from my side, but it'd be good if @compnerd could have a look as well. https://reviews.llvm.org/D41386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2017-12-19 Thread Leandro Lupori via Phabricator via cfe-commits
luporl updated this revision to Diff 127516. luporl added a comment. Addressed review comments. https://reviews.llvm.org/D41386 Files: include/__libunwind_config.h include/libunwind.h src/AddressSpace.hpp src/Registers.hpp src/UnwindCursor.hpp src/UnwindRegistersRestore.S src/Unwi

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2017-12-19 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: include/__libunwind_config.h:46 +# define _LIBUNWIND_CURSOR_SIZE 148 +# define _LIBUNWIND_HIGHEST_DWARF_REGISTER 110 # elif defined(__ppc__) Don't hardcode a number here; add a define `_LIBUNWIND_HIGHEST_DWARF_REGIS

[PATCH] D41386: [libunwind][PPC64] Port to ppc64le - initial version

2017-12-19 Thread Leandro Lupori via Phabricator via cfe-commits
luporl created this revision. luporl added a reviewer: mstorsjo. Initial working version of libunwind for PowerPC 64. Tested on little end ppc64 host only. Based on the existing PowerPC 32 code. It supports: - context save/restore (unw_getcontext, unw_init_local, unw_resume) - read/write from/t