rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/include/clang/Sema/Sema.h:5950
+ /// associated constraints of an older declaration of which it is a
+ /// redeclaration
+ bool CheckRedeclarationCon
saar.raz updated this revision to Diff 224898.
saar.raz marked 15 inline comments as done.
saar.raz added a comment.
Remove unrelated cleanup
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D41284/new/
https://reviews.llvm.org/D41284
Files:
clang/i
saar.raz updated this revision to Diff 209688.
saar.raz added a comment.
Rebase onto trunk.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D41284/new/
https://reviews.llvm.org/D41284
Files:
include/clang/AST/ASTNodeTraverser.h
include/clang/AST/DeclTemplate.h
saar.raz updated this revision to Diff 196074.
saar.raz added a comment.
- Address CR comments by rsmith
- Remove obsolete TODOs
- Fix redeclaration checking
- Change getAssociatedConstraints interface
- Add requires clause to ASTNodeTraverser
Repository:
rC Clang
CHANGES SINCE LAST ACT
rsmith added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:177
+ /// conjunction ("and").
+ llvm::SmallVector getAssociatedConstraints() const;
+
Returning a `SmallVector` by value is not idiomatic. If you need to make a copy
here, you should t
saar.raz updated this revision to Diff 194984.
saar.raz added a comment.
Rebase onto trunk
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D41284/new/
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.
Quuxplusone added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
saar.raz wrote:
> saar.raz wrote:
> > Rakete wrote:
> > > Quuxplusone wrote:
saar.raz added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
saar.raz wrote:
> Rakete wrote:
> > Quuxplusone wrote:
> > > saar.raz wrote:
> >
saar.raz added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
Rakete wrote:
> Quuxplusone wrote:
> > saar.raz wrote:
> > > Quuxplusone wrote:
Rakete added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
Quuxplusone wrote:
> saar.raz wrote:
> > Quuxplusone wrote:
> > > For my own edifi
Quuxplusone added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
saar.raz wrote:
> Quuxplusone wrote:
> > For my own edification, could you explai
saar.raz added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
Quuxplusone wrote:
> For my own edification, could you explain whether, given
>
>
Quuxplusone added inline comments.
Comment at:
test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/var-template-decl.cpp:10
+
+template requires bool(U())
+int B::A = int(U());
For my own edification, could you explain whether, given
#define BOOL bool
saar.raz updated this revision to Diff 161345.
saar.raz added a comment.
- Fix bad reference to getRequiresClause on TemplateDecl in assertion
Repository:
rC Clang
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.h
include/cl
saar.raz updated this revision to Diff 160861.
saar.raz added a comment.
- Address comments by rsmith, mainly removing associated constraints caching
and instead returning a smallvector of constraint expressions from
getAssociatedConstraints.
Repository:
rC Clang
https://reviews.llvm.org/D4
rsmith added inline comments.
Comment at: lib/AST/DeclTemplate.cpp:203
+
+Expr *TemplateDecl::getAssociatedConstraints() {
+ return getOrCollectAssociatedConstraints(getASTContext(),
Rather than producing an `Expr*` (which will presumably eventually need to
con
saar.raz updated this revision to Diff 159236.
saar.raz added a comment.
- Consider requires clause when determining if TPL has an unexpanded pack
Repository:
rC Clang
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.h
includ
saar.raz updated this revision to Diff 138500.
saar.raz added a comment.
Fixed reference to TemplateParams member in assertion.
Repository:
rC Clang
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Sema/Sema.h
saar.raz updated this revision to Diff 132748.
saar.raz added a comment.
Moved function into SemaConcept.cpp.
Repository:
rC Clang
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Sema/Sema.h
lib/AST/DeclTem
saar.raz updated this revision to Diff 129297.
saar.raz added a comment.
- Fixed wrong if that would cause valid instantiated requires clauses to not be
accepted.
Repository:
rC Clang
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/RecursiveASTV
saar.raz updated this revision to Diff 127163.
saar.raz added a comment.
- Added requires clause matching for all kinds of template redeclarations
instead of just classes.
Repository:
rC Clang
https://reviews.llvm.org/D41284
Files:
include/clang/AST/DeclTemplate.h
include/clang/AST/Recu
21 matches
Mail list logo
