This revision was automatically updated to reflect the committed changes.
Closed by commit rL320807: [clangd] Build in-memory index on symbols in files.
(authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41276?vs=127098&id=127099#toc
Repository:
rL LLVM
ioeric added a comment.
In https://reviews.llvm.org/D41276#956513, @sammccall wrote:
> I don't see `FileSymbols.{h,cpp}` being deleted, but maybe I'm bad at reading
> diffs.
No, I'm bad at creating diffs...
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41276
ioeric updated this revision to Diff 127098.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Removed unused files and addressed comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41276
Files:
clangd/CMakeLists.txt
clangd/index/FileIndex.cpp
clangd
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I don't see `FileSymbols.{h,cpp}` being deleted, but maybe I'm bad at reading
diffs.
Comment at: clangd/index/FileIndex.h:8
+//
+//===-
ioeric updated this revision to Diff 127087.
ioeric added a comment.
- Minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41276
Files:
clangd/CMakeLists.txt
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
unittests/clangd/CMakeLists.txt
unittests/clangd/
ioeric updated this revision to Diff 127086.
ioeric added a comment.
- Address review comments. Merge FileSymbols and tests into FileIndex.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41276
Files:
clangd/CMakeLists.txt
clangd/index/FileIndex.cpp
clangd/index/FileIndex.
sammccall added inline comments.
Comment at: clangd/index/FileMemIndexManager.h:23
+/// all symbols.
+class FileMemIndexManager {
+public:
Discussed offline a bit:
- FileIndex or PerFileIndex is a great name for this, if it implements
`Index`. So I think it sho
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41276
Files:
clangd/CMakeLists.txt
clangd/index/FileMemIndexManager.cpp
clangd/index/FileMe
