[PATCH] D41130: git-clang-format: cleanup: Use run() when possible.

2023-09-21 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Is this still relevant or can we close it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41130/new/ https://reviews.llvm.org/D41130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D41130: git-clang-format: cleanup: Use run() when possible.

2017-12-13 Thread Manuel Klimek via Phabricator via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D41130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41130: git-clang-format: cleanup: Use run() when possible.

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato created this revision. lodato added reviewers: djasper, klimek. This makes the code a bit easier to understand. Also add a docstring to `run()`. Note: This means that we read the entire index into memory when calling `git update-index`, whereas previously we would send the data line-by-li