[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-12 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. > Thanks, I've checked this in without the changes to TODO.TXT Thanks - that works for me. https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-12 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Thanks, I've checked this in without the changes to TODO.TXT. Please let me know if you still want them, otherwise I consider this to be complete. https://reviews.llvm.org/D40991 _

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-11 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added a comment. LGTM as-is with the changes to the TODO file... https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-11 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. Would you like me to drop the changes to TODO.TXT? https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. Except for the stuff in TODO.txt these look good to me. We need to do some work on that file - it's pretty out of date. https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-07 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT created this revision. [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII. I recently wrote a tool to audit MSVC's codebase for inconsistent line endings and unnecessary non-ASCII characters, and I ran it over libcxx's codebase too. I don't need any of these changes to be co