This revision was automatically updated to reflect the committed changes.
juliehockett marked 4 inline comments as done.
Closed by commit rL320841: [clang-tidy] Adding Fuchsia checker for virtual
inheritance (authored by juliehockett, committed by ).
Herald added a subscriber: klimek.
Changed pri
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some documentation nits, LGTM!
Comment at: docs/clang-tidy/checks/fuchsia-virtual-inheritance.rst:6
+
+Warns if classes are defined or created with v
juliehockett marked 3 inline comments as done.
juliehockett added inline comments.
Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36
+ // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that
inherits a virtual base class is disallowed [fuchsia-virt
juliehockett updated this revision to Diff 127033.
juliehockett added a comment.
Updating checker to only warn on declarations.
https://reviews.llvm.org/D40813
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/VirtualInheritanceCheck.cpp
aaron.ballman added inline comments.
Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36
+ // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that
inherits a virtual base class is disallowed [fuchsia-virtual-inheritance]
+ // CHECK-NEXT: D(int valu
juliehockett added inline comments.
Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:34-36
+ // CHECK-MESSAGES: [[@LINE-1]]:28: warning: constructing a class that
inherits a virtual base class is disallowed [fuchsia-virtual-inheritance]
+ // CHECK-NEXT: D(int value
juliehockett updated this revision to Diff 126804.
juliehockett marked an inline comment as done.
juliehockett added a comment.
Updated matcher to only match direct virtual base classes.
https://reviews.llvm.org/D40813
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyM
aaron.ballman added inline comments.
Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:30
+class D : public B, public C {
+ // CHECK-MESSAGES: [[@LINE-1]]:1: warning: virtual inheritance is disallowed
[fuchsia-virtual-inheritance]
+ // CHECK-NEXT: class C : public B,
juliehockett updated this revision to Diff 125560.
juliehockett marked 5 inline comments as done.
https://reviews.llvm.org/D40813
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fuchsia/FuchsiaTidyModule.cpp
clang-tidy/fuchsia/VirtualInheritanceCheck.cpp
clang-tidy/fuchsia/VirtualInhe
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:28-29
"fuchsia-default-arguments");
+CheckFactories.registerCheck(
+"fuchsia-virtual-inheritance");
}
Formatting looks off here.
==
Eugene.Zelenko added inline comments.
Comment at: test/clang-tidy/fuchsia-virtual-inheritance.cpp:42
+
+int main(void) {
+ A *a = new A(0);
void is redundant in C++. See modernize-redundant-void-arg.
https://reviews.llvm.org/D40813
_
juliehockett created this revision.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: xazax.hun, mgorny.
Adds a check to the Fuchsia module to warn if classes are defined or created
with virtual inheritance.
See https://fuchsia.googlesource.com/zircon/+/master/docs/cxx.m
12 matches
Mail list logo
