[PATCH] D40784: [clangd] Split code-completion tests out of ClangdTests. NFC.

2017-12-04 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319741: [clangd] Split code-completion tests out of ClangdTests. NFC. (authored by sammccall). Repository: rL LLVM https://reviews.llvm.org/D40784 Files: clang-tools-extra/trunk/clangd/CodeComplete.

[PATCH] D40784: [clangd] Split code-completion tests out of ClangdTests. NFC.

2017-12-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: unittests/clangd/CMakeLists.txt:16 JSONExprTests.cpp + TestFS.cpp TraceTests.cpp hokein wrote: > nit: maybe name it FSTests.cpp? to be consistent with other test file names. Ah, this is deliberately inconsistent

[PATCH] D40784: [clangd] Split code-completion tests out of ClangdTests. NFC.

2017-12-04 Thread Haojian Wu via Phabricator via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: unittests/clangd/CMakeLists.txt:16 JSONExprTests.cpp + TestFS.cpp TraceTests.cpp nit: maybe name it FSTests.cpp? to be consistent wi

[PATCH] D40784: [clangd] Split code-completion tests out of ClangdTests. NFC.

2017-12-04 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek. Common parts are mostly FS related, so pulled out TestFS.h for the common stuff. Deliberately resisted cleaning up much here, so this is pretty mechanical. Repository: rCTE Clang Tools Extra