[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-07 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D40752#948399, @jdenny wrote: > Alexey: I see that you committed the error message change, so I think this > issue is done. Is Abandon Revision correct in this scenario? Sorry, I'm new > here. Yes, it is correct https://reviews.llvm.org

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-07 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Alexey: I see that you committed the error message change, so I think this issue is done. Is Abandon Revision correct in this scenario? Sorry, I'm new here. https://reviews.llvm.org/D40752 ___ cfe-commits mailing list cfe

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In https://reviews.llvm.org/D40752#945572, @ABataev wrote: > In https://reviews.llvm.org/D40752#945571, @jdenny wrote: > > > In https://reviews.llvm.org/D40752#945255, @ABataev wrote: > > > > > In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > > > > > > > r319774

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D40752#945571, @jdenny wrote: > In https://reviews.llvm.org/D40752#945255, @ABataev wrote: > > > In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > > > > > r319774 works for my current use cases. Thanks. > > > > > > While we're on thi

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. In https://reviews.llvm.org/D40752#945255, @ABataev wrote: > In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > > > r319774 works for my current use cases. Thanks. > > > > While we're on this topic, do you happen to know the rationale behind the > > OpenMP restr

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In https://reviews.llvm.org/D40752#945234, @jdenny wrote: > r319774 works for my current use cases. Thanks. > > While we're on this topic, do you happen to know the rationale behind the > OpenMP restriction for which err_omp_union_type_not_allowed diagnoses > violation

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. r319774 works for my current use cases. Thanks. While we're on this topic, do you happen to know the rationale behind the OpenMP restriction for which err_omp_union_type_not_allowed diagnoses violations? I googled but couldn't find the rationale. If you would prefer

[PATCH] D40752: [OpenMP] Fix assert fail after target implicit map checks

2017-12-05 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. Fixed in a bit different way in r319774 https://reviews.llvm.org/D40752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits