This revision was automatically updated to reflect the committed changes.
Closed by commit rC319623: [WebAssembly] Pass through --undefined to Wasm LLD
(authored by sbc).
Repository:
rC Clang
https://reviews.llvm.org/D40739
Files:
lib/Driver/ToolChains/WebAssembly.cpp
Index: lib/Driver/To
sbc100 added a comment.
Sure I'll land this now.
Repository:
rC Clang
https://reviews.llvm.org/D40739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ncw added a comment.
I'm glad to be involved in a small way. Our company uses Emscripten in one of
our products, and some of our employees were early contributors to Emscripten
years ago, when they were trying to get C++ working. Now I've been allowed to
spend a few weeks "investigating" Wasm,
sbc100 added a comment.
By the way, thank you for all these wasm patches!
Repository:
rC Clang
https://reviews.llvm.org/D40739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbc100 added a comment.
Oh I see. lgtm. Do we need to update any tests? I see we won't have a
wasm-ld.c test yet? We should add one?
Repository:
rC Clang
https://reviews.llvm.org/D40739
___
cfe-commits mailing list
cfe-commits@lists.llvm.
ncw added a comment.
I didn't know it existed either, and you're right it's odd that it doesn't
appear in the help text... However it duly exists and is implemented in
clang/lib/Driver/ToolChains/Gnu.cpp, without any note that it's deprecated.
`man gcc` documents it.
Repository:
rC Clang
h
sbc100 added a comment.
I'm a little confused by this. I was assuming you would do "-Wl,-u,foo" or
"-Xlinker".I wasn't aware -u was a valid compiler flag itself. It doesn't
show up in --help.
Repository:
rC Clang
https://reviews.llvm.org/D40739
_
ncw updated this revision to Diff 125176.
ncw added a comment.
(D'oh, more trouble with arcane commands getting diffs into phabricator...
sorry for the spam.)
Repository:
rC Clang
https://reviews.llvm.org/D40739
Files:
lib/Driver/ToolChains/WebAssembly.cpp
Index: lib/Driver/ToolChains/W
ncw created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google,
dschuff, jfb, klimek.
This is a follow-on to https://reviews.llvm.org/D40724 (Wasm entrypoint changes
#1, add `--undefined` argument to LLD).
Repository:
rC Clang
https://reviews.llvm.org/D
