[PATCH] D40738: Don't use Wasm function sections for more than one function

2017-12-05 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC319801: [WebAssembly] Don't use Wasm function sections for more than one function (authored by djg). Repository: rC Clang https://reviews.llvm.org/D40738 Files: lib/Basic/Targets/OSTargets.h test/

[PATCH] D40738: Don't use Wasm function sections for more than one function

2017-12-05 Thread Nicholas Wilson via Phabricator via cfe-commits
ncw added a comment. Thanks for the review @sunfish (and for the other input you've given). Could you land this for me Dan, as I don't have commit access? Thanks. Repository: rC Clang https://reviews.llvm.org/D40738 ___ cfe-commits mailing list

[PATCH] D40738: Don't use Wasm function sections for more than one function

2017-12-01 Thread Dan Gohman via Phabricator via cfe-commits
sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. I think that was copied from LinuxTargetInfo before we figured out our current object file strategy. On native platforms, it's an icache optimization, because startup functions are all calle

[PATCH] D40738: Don't use Wasm function sections for more than one function

2017-12-01 Thread Nicholas Wilson via Phabricator via cfe-commits
ncw created this revision. Herald added subscribers: cfe-commits, aheejin, sbc100, dschuff, jfb. Fixes Bugzilla https://bugs.llvm.org/show_bug.cgi?id=35467 If a Wasm function section is created with more than one symbol, WasmObjectWriter fails with the following message: "function sections must