[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

2017-12-01 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. Yes, that comment is very out of date. The compiler-rt standalone build is essential to many of the users. It is quite common to build and use compiler-rt without LLVM (like sanitizer support in gcc). https://reviews.llvm.org/D40687 ___

[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

2017-12-01 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Ah, that's a bummer. compiler-rt's CMakeLists has this big shiny comment up top: # This build assumes that CompilerRT is checked out into the # 'projects/compiler-rt' or 'runtimes/compiler-rt' inside of an LLVM tree. # Standalone build system for CompilerRT is not

[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

2017-12-01 Thread Chris Bieneman via Phabricator via cfe-commits
beanz added a comment. This change isn't safe. Compiler-RT is buildable without LLVM's modules as long as you disable the tests, so you can't use an AddLLVM function inside AddCompilerRT unless it is only used when tests are disabled. https://reviews.llvm.org/D40687

[PATCH] D40687: [compiler-rt] Switch to add_llvm_install_targets

2017-11-30 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. Herald added subscribers: mgorny, dberris. This gains us the install-*-stripped targets, to strip binaries during installation. These targets otherwise mimic the existing install targets. https://reviews.llvm.org/D40687 Files: cmake/Modules/AddCompilerRT.cmake