[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

2017-12-08 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. Okay, that makes sense. Thanks for accommodating my use-case anyway! :D. Repository: rL LLVM https://reviews.llvm.org/D40685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

2017-12-08 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. The other runtime projects had the stripped installation targets added manually because they officially support being built completely standalone (i.e. without any LLVM components), so we can't rely on LLVM's CMake there. That's really unfortunate IMO, since it leads to

[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

2017-12-08 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. Hmm, this change means very recent LLVM is required to build libunwind-- previously I was able to use recent libunwind/libcxx/libcxxabi with LLVM 5 and LLVM 4. Other runtime projects (compiler-rt, libcxx, libcxxabi) were modified to support the new "strip-and-install"

[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

2017-11-30 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL319498: [libunwind] Switch to add_llvm_install_targets (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D40685 Files: libunwind/trunk/src/CMakeLists.txt Index: libunwind/trunk/s

[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

2017-11-30 Thread Chris Bieneman via Phabricator via cfe-commits
beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D40685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

2017-11-30 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai created this revision. Herald added a subscriber: mgorny. This gains us the install-unwind-stripped target, to perform stripping during installation. https://reviews.llvm.org/D40685 Files: src/CMakeLists.txt Index: src/CMakeLists.txt =