ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615
+
+ std::string Buffer;
+ if (Fn->hasFnAttribute("vector-variants")) {
mmasten wrote:
> ABataev wrote:
> > 1. Why this change is required?
> > 2. Why not a `SmallString`?
> Th
mmasten marked 2 inline comments as done.
mmasten added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615
+
+ std::string Buffer;
+ if (Fn->hasFnAttribute("vector-variants")) {
ABataev wrote:
> 1. Why this change is required?
> 2. Why not
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9615
+
+ std::string Buffer;
+ if (Fn->hasFnAttribute("vector-variants")) {
1. Why this change is required?
2. Why not a `SmallString`?
Comment at: clang/test/Op
mmasten updated this revision to Diff 194917.
mmasten added a comment.
Rebased and updated test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D40577/new/
https://reviews.llvm.org/D40577
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
clang/test/OpenMP/declare_simd_codegen.cpp
Index:
Hahnfeld added a reviewer: ABataev.
Hahnfeld added a comment.
This should add or extend a regression test
https://reviews.llvm.org/D40577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
mmasten added a comment.
This patch is related to revisions https://reviews.llvm.org/D22792 and
https://reviews.llvm.org/D40575
https://reviews.llvm.org/D40577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
mmasten created this revision.
This patch adds "vector-variants" function attributes to simd functions.
https://reviews.llvm.org/D40577
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
Index: lib/CodeGen/CGOpenMPRuntime.cpp
===
--- lib/C
