[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

2017-11-29 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79 QualifiedRenameRule(const NamedDecl *ND, - std::string NewQualifiedName) + const std::string &NewQualifiedName) : ND(ND), New

[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

2017-11-28 Thread Dmitry Venikov via Phabricator via cfe-commits
Quolyk added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79 QualifiedRenameRule(const NamedDecl *ND, - std::string NewQualifiedName) + const std::string &NewQualifiedName) : ND(ND), New

[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

2017-11-28 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: include/clang/Tooling/Refactoring/Rename/RenamingAction.h:79 QualifiedRenameRule(const NamedDecl *ND, - std::string NewQualifiedName) + const std::string &NewQualifiedName) : ND(ND), New

[PATCH] D40543: Pass by reference NewQualifiedName in QualifiedRenameRule

2017-11-28 Thread Dmitry Venikov via Phabricator via cfe-commits
Quolyk created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D40543 Files: include/clang/Tooling/Refactoring/Rename/RenamingAction.h Index: include/clang/Tooling/Refactoring/Rename/RenamingAction.h ==