Wizard updated this revision to Diff 124972.
Wizard added a comment.
restore file names
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNSErrorInitCheck.cpp
clang-tidy/objc/AvoidNSErrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tid
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319460: add new check to find NSError init invocation
(authored by Wizard).
Changed prior to commit:
https://reviews.llvm.org/D40528?vs=124972&id=124973#toc
Repository:
rL LLVM
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL319459: add new check to find NSError init invocation
(authored by Wizard).
Changed prior to commit:
https://reviews.llvm.org/D40528?vs=124972&id=124974#toc
Repository:
rL LLVM
https://reviews.llvm.
Wizard updated this revision to Diff 124971.
Wizard added a comment.
change file name cases
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNSEErrorInitCheck.cpp
clang-tidy/objc/AvoidNSEErrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
cla
Wizard added inline comments.
Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10
+``errorWithDomain:code:userInfo:`` to create new NSError objects instead
+of ``[NSError alloc] init]``. Otherwise it will lead to a warning message
+during compilation in Xcode.
-
Wizard updated this revision to Diff 124818.
Wizard marked 3 inline comments as done.
Wizard added a comment.
address comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNserrorInitCheck.cpp
clang-tidy/objc/AvoidNserrorInitCheck.h
cla
hokein added inline comments.
Comment at: clang-tidy/objc/AvoidNserrorInitCheck.cpp:31
+ diag(MatchedExpr->getLocStart(),
+ "use errorWithDomain:code:userInfo: to create a new NSError");
+}
not sure what's the best message here.
From apple's document:
>
Wizard added inline comments.
Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10
+``errorWithDomain:code:userInfo:`` to create new NSError objects instead
+of ``[NSError alloc] init]``. Otherwise it will lead to a warning message
+during compilation in Xcode.
-
hokein added inline comments.
Comment at: docs/clang-tidy/checks/objc-avoid-nserror-init.rst:10
+``errorWithDomain:code:userInfo:`` to create new NSError objects instead
+of ``[NSError alloc] init]``. Otherwise it will lead to a warning message
+during compilation in Xcode.
-
Wizard updated this revision to Diff 124486.
Wizard added a comment.
new line for doc
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNserrorInitCheck.cpp
clang-tidy/objc/AvoidNserrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/
Wizard created this revision.
Herald added subscribers: cfe-commits, mgorny, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40528
Files:
clang-tidy/objc/AvoidNserrorInitCheck.cpp
clang-tidy/objc/AvoidNserrorInitCheck.h
clang-tidy/objc/CMakeLists.txt
clang-tidy/obj
11 matches
Mail list logo
