Re: [PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

This has also shown up in a game engine middleware codebase, so it may be a broader issue - people seem to assume size_t is one of the int*_t types. On Wed, Aug 8, 2018 at 10:55 AM, Sam Clegg via Phabricator < revi...@reviews.llvm.org> wrote: > sbc100 added a comment. > > In https://reviews.llvm.

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

azakai added subscribers: sunfish, jgravelle-google. azakai added a comment. This has also shown up in a game engine middleware codebase, so it may be a broader issue - people seem to assume size_t is one of the int*_t types. Repository: rC Clang https://reviews.llvm.org/D40526 ___

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

sbc100 added a comment. In https://reviews.llvm.org/D40526#1192688, @sunfish wrote: > Is this related to the issue reported in the thread here > ? Ah yes, I'll follow up there. Repository: rC Clang https://reviews.l

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

sunfish added a comment. Is this related to the issue reported in the thread here ? Repository: rC Clang https://reviews.llvm.org/D40526 ___ cfe-commits mailing list cfe-c

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

sbc100 added a comment. Should we change int32_t as well? Or does the above code just need fixing? I'm a little concerned because this code is very portable which implies that WebAssembly might be doing something unusual here. Repository: rC Clang https://reviews.llvm.org/D40526 _

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

sbc100 added a comment. I'm running into an issue with an internal codebase that assumes that size_t is equivalent to either int32_t or int64_t which this change invalidates. After this change we have: size_t -> long int32_t -> int int64_t -> ling long int. e.g.: #include #include

[PATCH] D40526: [WebAssembly] Change size_t to `unsigned long`

This revision was automatically updated to reflect the committed changes. Closed by commit rC337783: [WebAssembly] Change size_t to `unsigned long`. (authored by djg, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D40526 Files: lib/Basi