[PATCH] D40302: Avoid copying the data of in-memory preambles

2017-11-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318945: Avoid copying the data of in-memory preambles (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D40302 Files: cfe/trunk/include/clang/Frontend/PrecompiledPreamble.h cfe

[PATCH] D40302: Avoid copying the data of in-memory preambles

2017-11-23 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D40302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D40302: Avoid copying the data of in-memory preambles

2017-11-23 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 124074. ilya-biryukov added a comment. - Fixed a typo. https://reviews.llvm.org/D40302 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/PrecompiledPreamble.cpp Index: lib/Frontend/PrecompiledPreamble.cpp =

[PATCH] D40302: Avoid copying the data of in-memory preambles

2017-11-23 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:101 /// is accessible. + /// For in-memory preambles, PrecompiledPreamble instance continues to owns + /// the MemoryBuffer with the Preamble after this method returns. The caller ---

[PATCH] D40302: Avoid copying the data of in-memory preambles

2017-11-21 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. Preambles are large and we should prefer not to copy it. https://reviews.llvm.org/D40302 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/PrecompiledPreamble.cpp Index: lib/Frontend/PrecompiledPreamble.cpp ==