[PATCH] D40301: [clangd] Ensure preamble outlives the AST

2017-11-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL318944: [clangd] Ensure preamble outlives the AST (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D40301 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp clang-tools-extr

[PATCH] D40301: [clangd] Ensure preamble outlives the AST

2017-11-24 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 124167. ilya-biryukov added a comment. - Moved PreambleData declaration up to avoid fwd-decl. https://reviews.llvm.org/D40301 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h Index: clangd/ClangdUnit.h

[PATCH] D40301: [clangd] Ensure preamble outlives the AST

2017-11-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/ClangdUnit.h:51 +struct PreambleData; + can you move the definition here to avoid the extra decl? (I tend to find this more re

[PATCH] D40301: [clangd] Ensure preamble outlives the AST

2017-11-21 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. In-memory preambles will not be copied anymore, so we need to make sure they outlive the AST. https://reviews.llvm.org/D40301 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h Index: clangd/ClangdUnit.h ===