martell added a comment.
In https://reviews.llvm.org/D40285#931248, @mstorsjo wrote:
> I'm a little divided - either we remove both WIN32 and WIN64 from all mingw
> configurations, or we add the missing WIN32 for x86_64 mingw. Removing would
> be the strictly correct thing to do, but I'm sure i
mstorsjo added a comment.
In https://reviews.llvm.org/D40285#931242, @martell wrote:
> The easy one is to get rid of WIN64 because gcc doesn't even do that for
> mingw.
Yes it does, it behaves just the same as WIN32:
$ x86_64-w64-mingw32-gcc -E -dM - < /dev/null | grep WIN64
#define _WIN6
martell added a comment.
... also WINNT was defined for X86 so I just added that to note it.
what do you suggest we do with that one.
Repository:
rL LLVM
https://reviews.llvm.org/D40285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
martell added a comment.
In https://reviews.llvm.org/D40285#931241, @mstorsjo wrote:
> ... so in general I wouldn't mind doing a change like this, but I'd like to
> make it consistent on ARM, i386 and x86_64 at the same time in that case,
> instead of just changing aarch64.
Thanks for the qui
martell updated this revision to Diff 123728.
Repository:
rL LLVM
https://reviews.llvm.org/D40285
Files:
lib/Basic/Targets/AArch64.cpp
lib/Basic/Targets/X86.h
test/Preprocessor/predefined-macros.c
Index: test/Preprocessor/predefined-macros.c
mstorsjo added a comment.
... so in general I wouldn't mind doing a change like this, but I'd like to
make it consistent on ARM, i386 and x86_64 at the same time in that case,
instead of just changing aarch64.
Repository:
rL LLVM
https://reviews.llvm.org/D40285
__
mstorsjo added a comment.
> WIN32 and WIN64 are not real definitions they are typically defined by the
> system headers, _WIN32 and _WIN64 are the compiler definitions.
Almost.
In MSVC, WIN32 and WIN64 are never defined by the compiler, neither by system
headers. Project files created by the I
martell created this revision.
Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson.
_WIN32 is already defined in lib/Basic/Targets/OSTargets.h
WIN32 and WIN64 are not real definitions they are typically
defined by the system headers, _WIN32 and _WIN64 are the
compiler definit
