jtbandes added a comment.
Please take another look when you get a chance :)
Repository:
rC Clang
https://reviews.llvm.org/D40284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jtbandes updated this revision to Diff 133440.
jtbandes added a comment.
Using a slightly more invasive fix. I haven't come up with any other test cases
that exhibit the problem, which makes me unsure this fix is needed in all these
locations. Maybe someone with more knowledge of this function c
rsmith added a comment.
I would prefer that we make the more-invasive fix, and make each error case
within template argument deduction set all the deduction failure information.
(Consider factoring out the error setup into helper functions too.) The current
approach is a maintenance problem in
lichray added a comment.
I'm not confident enough about the effects of this patch with only one test;
the last patch also passes the test. I hope I can understand the effects
better.
https://reviews.llvm.org/D40284
___
cfe-commits mailing list
cf
jtbandes added a comment.
Bump :)
https://reviews.llvm.org/D40284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jtbandes updated this revision to Diff 124033.
jtbandes added a comment.
@erik.pilkington Updated to use a wrapper function. This is definitely less
invasive, but it could defeat some optimizations (any approach that checks the
return value will defeat tail recursion, I suppose...)
https://rev
erik.pilkington added a comment.
This looks correct, but I definitely agree that RAII would make this a lot
nicer. Have you considered adding a `CancelableSaveAndRestore` or something to
SaveAndRestore.h? It seems useful and generic enough to make it worthwhile.
Otherwise, you could just write
jtbandes added a reviewer: rsmith.
jtbandes added a subscriber: rsmith.
jtbandes added a comment.
Adding @rsmith for review based on the commit history of
SemaTemplateDeduction.cpp :)
https://reviews.llvm.org/D40284
___
cfe-commits mailing list
cfe
