[PATCH] D40261: Add default argument AST matcher

2017-11-21 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r318794, thank you! https://reviews.llvm.org/D40261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40261: Add default argument AST matcher

2017-11-20 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett added a comment. It'd be great if you could commit it -- I don't have commit privileges. Much appreciated! https://reviews.llvm.org/D40261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D40261: Add default argument AST matcher

2017-11-20 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 123701. juliehockett marked an inline comment as done. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersNarrowin

[PATCH] D40261: Add default argument AST matcher

2017-11-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I did find a few more spurious semicolons with the testing code as well. If you need me to commit this on your behalf, I'm happy to do so, though it won't happen until tomorrow or Wed. Or, if you have commit privs, feel free to commit with the fixed test case.

[PATCH] D40261: Add default argument AST matcher

2017-11-20 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 123654. juliehockett added a comment. Removed spurious semicolons https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMat

[PATCH] D40261: Add default argument AST matcher

2017-11-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor nit with the comments leading to the public docs, LGTM! Comment at: include/clang/ASTMatchers/ASTMatchers.h:5825-5826 +/// \code +/// void x(

[PATCH] D40261: Add default argument AST matcher

2017-11-20 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 123646. juliehockett added a comment. Updated Registry.cpp to include new matcher. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/A

[PATCH] D40261: Add default argument AST matcher

2017-11-20 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. You should also update lib\ASTMatchers\Dynamic\Registry.cpp to have the new matcher (be sure to keep the new matcher alphabetized as well). https://reviews.llvm.org/D40261 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D40261: Add default argument AST matcher

2017-11-20 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. Herald added a subscriber: klimek. Adds AST matcher for declarations with default arguments. https://reviews.llvm.org/D40261 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersNarrowingTest.