mgrang added inline comments.
Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:47
+Features.push_back("+d");
+break;
+ }
Can you also add a case for pushing back +c here?
https://reviews.llvm.org/D39963
__
asb marked an inline comment as done.
asb added a comment.
In https://reviews.llvm.org/D39963#931026, @apazos wrote:
> Can you push this as a patch to review/commit instead of RFC? It has received
> a lot of comments/corrections already and I think it is getting in a shape we
> can merge.
I m
apazos added a comment.
Can you push this as a patch to review/commit instead of RFC? It has received a
lot of comments/corrections already and I think it is getting in a shape we can
merge.
Comment at: lib/Driver/ToolChains/RISCV.cpp:86
+CmdArgs.push_back("-lc");
+Cm
mgrang added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.cpp:1823
+ "riscv64-unknown-linux-gnu",
+ "riscv32-unknown-elf"};
+
I suppose we need riscv64-unknown-elf h
mgrang added inline comments.
Comment at: test/Driver/riscv64-toolchain.c:1
+// A basic clang -cc1 command-line, and simple environment check.
+
mgrang wrote:
> I just saw that this test fails with the error:
>
> error: backend data layout 'e-m:e-i64:64-n32:64-S
asb marked 4 inline comments as done.
asb added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.cpp:86
+CmdArgs.push_back("-lc");
+CmdArgs.push_back("-lgloss");
+CmdArgs.push_back("--end-group");
asb wrote:
> apazos wrote:
> > mgrang wrote:
>
asb updated this revision to Diff 123229.
asb marked an inline comment as done.
asb added a comment.
Consider this a WIP update. This is not yet ready for merging, but could still
benefit from feedback.
This update adds support for RISC-V to the Linux toolchain driver, which
includes support fo
mgrang added inline comments.
Comment at: test/Driver/riscv64-toolchain.c:1
+// A basic clang -cc1 command-line, and simple environment check.
+
I just saw that this test fails with the error:
error: backend data layout 'e-m:e-i64:64-n32:64-S128' does not match
mgrang added a comment.
@asb I cherry-picked this patch and was able to compile a simple program for
elf triple. By manually adding a few libs on the link line I was also able to
make it link for linux triple.
Could you please respond to the comment about risv32-ld? Other than that this
patch L
asb added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.cpp:86
+CmdArgs.push_back("-lc");
+CmdArgs.push_back("-lgloss");
+CmdArgs.push_back("--end-group");
apazos wrote:
> mgrang wrote:
> > How about if our sysroot is linux (as opposed to e
apazos added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.cpp:86
+CmdArgs.push_back("-lc");
+CmdArgs.push_back("-lgloss");
+CmdArgs.push_back("--end-group");
mgrang wrote:
> How about if our sysroot is linux (as opposed to elf)? There won'
mgrang added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.cpp:86
+CmdArgs.push_back("-lc");
+CmdArgs.push_back("-lgloss");
+CmdArgs.push_back("--end-group");
How about if our sysroot is linux (as opposed to elf)? There won't be any
libglo
johnrusso added inline comments.
Comment at: lib/Driver/ToolChains/RISCV.h:42
+ : GnuTool("RISCV::Linker",
+TC.getTriple().isArch64Bit() ? "riscv64-ld" : "riscv32-ld",
+TC) {}
I wonder if we should construct the linker name ba
asb created this revision.
Herald added subscribers: jordy.potman.lists, simoncook, johnrusso, rbar,
mgorny.
I'm marking this as an RFC as I'd initially like to get feedback on the testing
approach and structure of this patch (is this about the right granularity or
would you prefer to start wit
14 matches
Mail list logo
